listbase: Static analysis fixes

diff --git a/gtk/gtklistbase.c b/gtk/gtklistbase.c
index 41e25858f5d053ef3f31ff900f31dfb0872b6bba..5ef58dd4a4e93ebf9d42fbbcccbd5e41a8cf377d 100644 (file)
--- a/gtk/gtklistbase.c
+++ b/gtk/gtklistbase.c
@@ -439,19 +439,20 @@ gtk_list_base_select_item (GtkListBase *self,
        * by the model, fall through to normal setting.
        */
     }
+
   if (success)
     return;
 
   if (modify)
     {
       if (gtk_selection_model_is_selected (model, pos))
-        success = gtk_selection_model_unselect_item (model, pos);
+        gtk_selection_model_unselect_item (model, pos);
       else
-        success = gtk_selection_model_select_item (model, pos, FALSE);
+        gtk_selection_model_select_item (model, pos, FALSE);
     }
   else
     {
-      success = gtk_selection_model_select_item (model, pos, TRUE);
+      gtk_selection_model_select_item (model, pos, TRUE);
     }
 
   gtk_list_item_tracker_set_position (priv->item_manager,